Repository navigation
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (5)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review. WalkthroughShared-link response types and the default mock now include an expiration capability. Item conversion uses the server-provided capability to set ChangesShared-link expiration capability
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable merge-blocking risk remains in the reviewed changes. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 Biome (2.5.14)src/common/types/core.jsFile contains syntax errors that prevent linting: Line 126: type alias are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 476: 'export type' declarations are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 37: 'import type' are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 39: type alias are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 40: type alias are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 41: type alias are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 43: type alias are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 50: type alias are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 51: type alias are a ... [truncated 6627 characters] ... onvert your file to a TypeScript file or remove the syntax.; Line 447: type alias are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 455: type alias are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 459: type alias are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 463: type alias are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 465: Expected a statement but instead found ', src/elements/content-sharing/types.jsFile contains syntax errors that prevent linting: Line 7: 'import type' are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 156: Expected a semicolon or an implicit semicolon after a statement, but found none; Line 158: Expected a type but instead found '?'.; Line 161: Expected a type but instead found '?'.; Line 161: Expected a property, or a signature but instead found ','.; Line 187: Expected a type but instead found '?'.; Line 187: Expected a property, or a signature but instead found ';'.; Line 2: 'import type' are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 6: 'import type' are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 193: Expected a statement but instead found '}'.; Line 18: 'import type' are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 27: type alias are a TypeScript only feature. Co ... [truncated 948 characters] ... pected an expression but instead found '}'.; Line 132: ';' expected'; Line 132: Expected a property, or a signature but instead found ','.; Line 135: Type annotations are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 137: Expected a semicolon or an implicit semicolon after a statement, but found none; Line 139: Type annotations are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 143: Type annotations are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 147: Type annotations are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 149: Expected a semicolon or an implicit semicolon after a statement, but found none Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the link at night Comment |
7d71272 to
fa7f945
Compare
|
|
||
| type SharedLinkFeatures = { | ||
| download_url: boolean, | ||
| expiration?: boolean, |
There was a problem hiding this comment.
wouldn't expiration always exist now since we have added the field in the response
There was a problem hiding this comment.
ah yeah you're right
| shared_link?: APISharedLink, | ||
| shared_link_features: { | ||
| download_url: boolean, | ||
| expiration?: boolean, |
This branch has not been deployed
2 participants
MOTIVATION
Desktop Content Sharing turned Link Expiration on when the user could change the shared link access level and an editor role was allowed.
GET /2.0/files/{id}?fields=shared_link_featuresnow returnsexpirationfor that permission. The switch follows that value.BEFORE
expirationvalue uses that same checkAFTER
shared_link_features.expirationis trueexpirationvalue leaves the switch offSummary by CodeRabbit